MVC Foolproof Validation

Closed Issue: GreaterThan and LessThan attributes not working with unobtrusive js [15188]

rbihun — Thu, 16 May 2013 10:58:41 GMT

In my view model i have similar to the following:

[Required]
[Range(0, 1000, ErrorMessage = "Please enter a value greater than 0.")]
[Display(Name = "Low Value")]
public double LowValue { get; set; }

[Required]
[Range(0, 1000, ErrorMessage = "Please enter a value greater than 0.")]
[GreaterThan("LowValue", ErrorMessage = "Your high value needs to be greater than your low value.")]
[Display(Name = "High Value")]
public double HighValue { get; set; }

I have unobtrusive js enabled in an MVC3 application using the Razor view engine (.NET 4) when. When i run the application and type in 70 for my "low value" and 120 for my "high value" i get a validation error that says "Your high value needs to be greater than your low value" Same results when I tried this with out the "Range" attribute.

In addition (thinking the attributes worked the other way) I added the "LessThan" attribute on my "High" value and receive zero javascript validation when "high" is greaterthan or lessthan "low" (but accurate validation when i run Modelstate.IsValid)

New Post: Manually trigger foolproof validation

thelameduck — Fri, 03 May 2013 16:59:27 GMT

I'm using Foolproof Validation so I can use [RequiredIf] attributes on my view model. The problem is that I'd like to trigger validation within my code using the same logic outside a controller.

I've tried creating my own validation context and using Validatior.TryValidateObject; however, it fails with Foolproof's custom RequiredIf validator. Is there a way to take my model and validate it other than passing it to a controller?

Am I using the wrong approach?

Here is my code:

var draftModel = _draftHelper.LoadDraft(draftId);

var validationResults = new List<ValidationResult>();

var vc = new ValidationContext(draftModel, null, null);

var isValidDraft = Validator.TryValidateObject(draftModel, vc, 
                                               validationResults, true);

And the error I get is on the TryValidateObject line

System.NotImplementedException: The method or operation is not implemented.

I've also posted on StackOverflow, but I'll update both posts with the answer when I find it.

New Post: Why do we need to implement IsValid in ModelAwareValidationAttribute ?

DrKawashima — Tue, 30 Apr 2013 12:20:43 GMT

Hi,
I just downloaded the source code, imported the files into my own project and tried to implement my frist validator (a RequiredIsTrue)
When I executed the project I got an exception. The IsValid method in ModelAwareValidationAttribute.cs had fired a NotImplementedException.

Was quite surprised that this method fired.
Doesn't the specific validators, like RequiredIfTrue have their own validators??

Is there something I'm missing or is it supposed to work like this?
In case of the latter, I'd like some advice on how to implement a simple solution where I can just leave the validation up to the specific data annotation validators themselves and don't have to write any custom code in the ModelAwareValidationAttribute.

Note that If I do implement the isValid method (for instance set it to always return true), all aspects of the validation do work as expected. It's just that I don't WANT to have to perform the validation in that method...

New Post: Minor suggestion to remove cultural bias from project home page examples

sgryphon — Tue, 30 Apr 2013 03:00:59 GMT

The fourth example on the project home page (for Required Validation) uses "FirstName" and "LastName", which are culturally biased terms.

This is just a minor suggestion to change them to be GivenName and Surname (or GivenName and FamilyName), which are more culturally neutral.

For an in depth discussion of the issue see: http://www.w3.org/International/questions/qa-personal-names

New Post: Custom Validation no client side validation

Lukehenners — Mon, 22 Apr 2013 12:53:13 GMT

With MVC4 there is an interface which has to be implemented which isn't implemented within foolproof, I have created my own subset of annotations based upon the very good foolproof code which does implement the interface and this works perfectly with mvcfoolprooj.unobtrusive.js. The interface is IClientValidatable.

public abstract class ModelAwareAttribute : ValidationAttribute, IClientValidatable
{
  //...
  public IEnumerable<ModelClientValidationRule> GetClientValidationRules(ModelMetadata metadata, ControllerContext context)
  {
    yield return new ModelClientValidationRule()
    {
      ErrorMessage = ErrorMessage,
      ValidationType = "is"
    };
  }
}

Commented Issue: Destination Property should use Display Name if available. [18242]

peterrow — Tue, 09 Apr 2013 13:11:02 GMT

For the property comparison validators, like GreaterThan, it uses the destination property in the error message.

"Start Date should be greater than EndDate"

Though the system uses the DisplayName value for the current property, it should also use the DisplayName value for the destination property, if available.

"Start Date should be greater than End Date"
Comments: ** Comment from web user: peterrow **

I would say that the impact is medium or high.
Without this whenever a validation message is shown it is displayed incorrect, this looks bad to clients of my software. The only workaround is to hardcode the error message - not nice, especially for localisation.

New Post: Custom Validation no client side validation

jaina — Wed, 03 Apr 2013 15:08:25 GMT

Hello all,

I tried to implement the example in

http://www.nickriggs.com/posts/build-model-aware-custom-validation-attributes-in-asp-net-mvc-2/

But the custom client side validation is not happening.

I am using MVC 4.0.

I have used @Scripts.Render("~/Scripts/mvcfoolproof.unobtrusive.min.js") in my View.

Please advise on what m I missing.

Thanks in advance.

Commented Issue: Issue - NotImplementedException [17357]

manuel0081 — Thu, 21 Feb 2013 11:03:04 GMT

http://forums.asp.net/post/4749014.aspx
 
http://forums.asp.net/t/1752975.aspx/1?Conditional+validation+with+MVC+Foolproof+Validation+
Comments: ** Comment from web user: manuel0081 **

related to #15609. Can be closed.

Commented Issue: "The method or operation is not implemented." - ValidationAttributes and Entity Framework 4 [15609]

manuel0081 — Thu, 21 Feb 2013 10:52:24 GMT

Hi,
 
There doesn't appear to be anything about this issue in the discussions or issue tracker. Must say, before I begin, I like what you've been doing and would very much like to make use of this library in my MVC 3 projects.
 
Anyway, it looks like there's an issue with the 'IsAttribute' attributes (not tested the RequiredIf attributes) when used in conjunction with the Entity Framework (I'm using EF 4.1 with Code First). When EF is trying to SaveChanges() the following exception is being raised:
 
[NotImplementedException: The method or operation is not implemented.]
 Foolproof.ModelAwareValidationAttribute.IsValid(Object value) +28
 System.ComponentModel.DataAnnotations.ValidationAttribute.IsValid(Object value, ValidationContext validationContext) +108
 System.ComponentModel.DataAnnotations.ValidationAttribute.GetValidationResult(Object value, ValidationContext validationContext) +29
 System.Data.Entity.Internal.Validation.ValidationAttributeValidator.Validate(EntityValidationContext entityValidationContext, InternalMemberEntry property) +107
 
Not hugely familiar with EF to be able to give you any detailed suggestions/fixes but, since the error is coming from ModelAwareValidationAttribute, I suspect the issue lies around when the validation attributes are being instantiated or something to do with the object inheritance hierarchy.
 
Hope this helps.
 
Cheers,
Jonny
Comments: ** Comment from web user: manuel0081 **

Impact low? change to urgent! It's related to Entity Framework... it's very important to resolve.

Commented Issue: "The method or operation is not implemented." - ValidationAttributes and Entity Framework 4 [15609]

manuel0081 — Thu, 21 Feb 2013 10:45:09 GMT

I have too

New Post: Entity Framework Not Implemented Exception Solution

manuel0081 — Wed, 20 Feb 2013 14:29:57 GMT

A sample?

Created Issue: How to get VB.Net verion of this code (MVC Validation) [19216]

Pughalveni — Mon, 21 Jan 2013 11:21:07 GMT

Please let me know

Commented Issue: RequiredIf not working with radio buttons [18872]

nairik — Wed, 16 Jan 2013 09:03:22 GMT

Hi,
I want validate the radio button with reuiredIf attribute using dependent value but client side validation deosnt work for radio button. any help!!
Comments: ** Comment from web user: nairik **

Hi,

Same bug for me, but i suspect that client validation is not working when using sub classes inside your view model.

Example :

public class Test1ViewModel
{
public Test2ViewModel model2 {get;set;}
}

public class Test2ViewModel
{
public bool bool1{get;set;}

[RequiredIfTrue("bool1")] // This is not working on client side. Please fix this bug :)
public string string1{get;set;}

}

Created Issue: GreaterThan operator compare only days on 'dd M yy' formatted date [19185]

ynevet — Mon, 14 Jan 2013 08:27:52 GMT

When comparing 2 dates with the 'dd M yy' format using the GreaterThan operator:
Begin: 16 Jan 2013
End: 06 Feb 2013

The GreaterThan operator only check the days instead of the entire date(day, month and year) and as a result of it 16 days is greater than 06 days and the validation failed: 'Begin must be greater than End', which is obviously unwanted behavior.

Please help.

Thank you

Commented Issue: Support internation date and time formats [17417]

stare — Fri, 07 Dec 2012 06:41:55 GMT

Please add support for international date and time formats in client validation (unobtrusive)
 
Such as 'dd/mm/yyyy' and 'dd.mm.yyyy'

Comments: ** Comment from web user: stare **

Second that!

New Post: Entity Framework Not Implemented Exception Solution

shuzz — Tue, 04 Dec 2012 11:26:21 GMT

If you are getting the Not Implemented Exception on your EF Models, this is what I did to *fix* it:

My solution has a domain project (POCO) with the repositories in there too and a website project.

I was trying to utilize the same POCO models as the models website, adding the [RequiredIfEmpty("field")] anotations right there. bad idea to begin with, I know.

What I ended up doing was creating ViewModels on the website with all the fields as the POCO plus the validation Annotations, i also added AutoMapper to map the POCO and the ViewModels easily.

By doing this i was able to fully utilize the

MVC Foolproof Validation. not only that but my solution is a lot more decoupled and the domain is a lot lighter.

while this doesn't really solves the Not Implemented Exception, it gives you a work around it.

hope this helps.

New Post: RequiredIfTrue client side validation

nickriggs — Tue, 27 Nov 2012 14:34:33 GMT

Hey guys. I made a quick example project using Robelind's original example. The only thing I changed was adding a hidden input for the bool property like I mentioned before. Clientside seems validation works fine in MVC 4. Hope this helps:

https://dl.dropbox.com/u/73019/Examples/QuickTest.zip

New Post: RequiredIfTrue client side validation

robelind — Tue, 27 Nov 2012 13:22:27 GMT

Sorry to nag you, but will there be an update for MVC 4?

Reviewed: Beta 0.9.4517 (Nov 27, 2012)

eefhert — Tue, 27 Nov 2012 09:00:26 GMT

Rated 5 Stars (out of 5) - This is really excellent work! I recently started building an MVC 3 website which has rather complicated forms with nested radiobuttons. So the RequiredIf attribute is a not to miss validation option! I like to see some donate button so we can support this kind of codeplex gems. Best regards, Evert

Commented Issue: RequiredIf using Regex against number field never validates [18974]

jwynveen — Mon, 26 Nov 2012 22:56:12 GMT

I have a state field that is only required if the user select USA or Canada from a dropdown. I used RequiredIf with the RegExMatch operator. This works perfectly with server side validation, but the unobtrusive validation never shows that field as invalid.

[RequiredIf("Country", Operator.RegExMatch, "(1033|4105)", ErrorMessage = "{0} is required")]
public string State { get; set; }

[Required(ErrorMessage = "{0} is required")]
public int Country { get; set; }

Looking at the source of mvcfoolproof.unobtrusive.js, the issue is because it is parsing value2 ("(1033|4105)") to a number because it sees that value1 ("1033") is a number. This makes the RegEx never fail because value2 is NaN.

Here is how I changed that block of code to make it work. Essentially I'm keeping the original values around even after being parsed, because you should never parse the regex pattern.

===== Code Fix =====
var originalValue1 = value1;
var originalValue2 = value2;
if (isDate(value1)) {
value1 = Date.parse(value1);
value2 = Date.parse(value2);
}
else if (isBool(value1)) {
if (value1 == "false") value1 = false;
if (value2 == "false") value2 = false;
value1 = !!value1;
value2 = !!value2;
}
else if (isNumeric(value1)) {
value1 = parseFloat(value1);
value2 = parseFloat(value2);
}

switch (operator) {
case "EqualTo": if (value1 == value2) return true; break;
case "NotEqualTo": if (value1 != value2) return true; break;
case "GreaterThan": if (value1 > value2) return true; break;
case "LessThan": if (value1 < value2) return true; break;
case "GreaterThanOrEqualTo": if (value1 >= value2) return true; break;
case "LessThanOrEqualTo": if (value1 <= value2) return true; break;
case "RegExMatch": return (new RegExp(originalValue2)).test(value1); break;
case "NotRegExMatch": return !(new RegExp(value2)).test(value1); break;
}
Comments: ** Comment from web user: jwynveen **

The other option would be to parse value1 and value2 separately since they very well could be different types. Something like this:

if (isDate(value1)) {
value1 = Date.parse(value1);
}
else if (isBool(value1)) {
if (value1 == "false") value1 = false;
value1 = !!value1;
}
else if (isNumeric(value1)) {
value1 = parseFloat(value1);
}
if (isDate(value2)) {
value2 = Date.parse(value2);
}
else if (isBool(value2)) {
if (value2 == "false") value2 = false;
value2 = !!value2;
}
else if (isNumeric(value2)) {
value2 = parseFloat(value2);
}
==end code==
That could obviously be cleaned up into a shared function that parses each value, but I think you get the point.

MVC Foolproof Validation

Closed Issue: GreaterThan and LessThan attributes not working with unobtrusive js [15188]

New Post: Manually trigger foolproof validation

New Post: Why do we need to implement IsValid in ModelAwareValidationAttribute ?

New Post: Minor suggestion to remove cultural bias from project home page examples

New Post: Custom Validation no client side validation

Commented Issue: Destination Property should use Display Name if available. [18242]

New Post: Custom Validation no client side validation

Commented Issue: Issue - NotImplementedException [17357]

Commented Issue: "The method or operation is not implemented." - ValidationAttributes and Entity Framework 4 [15609]

Commented Issue: "The method or operation is not implemented." - ValidationAttributes and Entity Framework 4 [15609]

New Post: Entity Framework Not Implemented Exception *Solution*

Created Issue: How to get VB.Net verion of this code (MVC Validation) [19216]

Commented Issue: RequiredIf not working with radio buttons [18872]

Created Issue: GreaterThan operator compare only days on 'dd M yy' formatted date [19185]

Commented Issue: Support internation date and time formats [17417]

New Post: Entity Framework Not Implemented Exception *Solution*

New Post: RequiredIfTrue client side validation

New Post: RequiredIfTrue client side validation

Reviewed: Beta 0.9.4517 (Nov 27, 2012)

Commented Issue: RequiredIf using Regex against number field never validates [18974]

New Post: Entity Framework Not Implemented Exception Solution

New Post: Entity Framework Not Implemented Exception Solution