foolproof Issue Tracker Rss Feed

Commented Issue: Could not load file or assembly System.Web.Mvc, Version=2.0.0.0 during unit test [18815]

desmond80in — Sat, 15 Jun 2013 14:55:26 GMT

I get the following exception when trying to run an NUnit test to verify AutoMappers configuration. I don't know why its looking for MVC 2.0? I am using MVC 4.0.0 dlls in my main app and Foolproof works fine at runtime.

Any ideas?

{{
System.TypeInitializationException : The type initializer for 'Foolproof.ContingentValidationAttribute' threw an exception.
----> System.IO.FileLoadException : Could not load file or assembly 'System.Web.Mvc, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
at System.Reflection.CustomAttribute._CreateCaObject(RuntimeModule pModule, IRuntimeMethodInfo pCtor, Byte** ppBlob, Byte* pEndBlob, Int32* pcNamedArgs)
at System.Reflection.CustomAttribute.CreateCaObject(RuntimeModule module, IRuntimeMethodInfo ctor, ref IntPtr blob, IntPtr blobEnd, ref Int32 namedArgs)
at System.Reflection.CustomAttribute.GetCustomAttributes(RuntimeModule decoratedModule, Int32 decoratedMetadataToken, Int32 pcaCount, RuntimeType attributeFilterType, Boolean mustBeInheritable, IList derivedAttributes, Boolean isDecoratedTargetSecurityTransparent)
at System.Reflection.CustomAttribute.GetCustomAttributes(RuntimePropertyInfo property, RuntimeType caType)
at AutoMapper.ConfigurationStore.CreateMappingExpression(TypeMap typeMap)
at AutoMapperConfig.Configure() in AutomapperConfig.cs: line 35
at MyApp.Test.AutomapperConfigurationTest.ValidationAutomapperConfiguration() in AutomapperConfigurationTest.cs: line 11
--FileLoadException
at Foolproof.Register.Attribute(Type foolprooftAttributeType)
at Foolproof.Register.All()
}}
Comments: ** Comment from web user: desmond80in **

Thanks bro this resolved my issue thanks for the valuable input..

Reopened Issue: GreaterThan and LessThan attributes not working with unobtrusive js [15188]

rbihun — Fri, 14 Jun 2013 07:26:12 GMT

In my view model i have similar to the following:

[Required]
[Range(0, 1000, ErrorMessage = "Please enter a value greater than 0.")]
[Display(Name = "Low Value")]
public double LowValue { get; set; }

[Required]
[Range(0, 1000, ErrorMessage = "Please enter a value greater than 0.")]
[GreaterThan("LowValue", ErrorMessage = "Your high value needs to be greater than your low value.")]
[Display(Name = "High Value")]
public double HighValue { get; set; }

I have unobtrusive js enabled in an MVC3 application using the Razor view engine (.NET 4) when. When i run the application and type in 70 for my "low value" and 120 for my "high value" i get a validation error that says "Your high value needs to be greater than your low value" Same results when I tried this with out the "Range" attribute.

In addition (thinking the attributes worked the other way) I added the "LessThan" attribute on my "High" value and receive zero javascript validation when "high" is greaterthan or lessthan "low" (but accurate validation when i run Modelstate.IsValid)

Created Unassigned: unobtrusive script depends on element.id [19832]

mcshaz — Sun, 09 Jun 2013 21:46:05 GMT

when MVC 4 uses a helper within a loop such as:

@for (int i=0;i<Foo.length;i++)
{
@Html.EditorFor(model=>model[i].Bar)
or
@Html.TextBoxFor(model=>model[i].Bar)
}

No id attribute is created. obviously the user can use @Html.TextBoxFor(model=>model[i].bar, new { id=string.Format("[{0}]_Bar", i)}), but the advantage of using Linq within a helper is lost.

This causes a number of methods to create errors within the javascript.

Closed Issue: GreaterThan and LessThan attributes not working with unobtrusive js [15188]

rbihun — Thu, 16 May 2013 10:58:41 GMT

Commented Issue: Destination Property should use Display Name if available. [18242]

peterrow — Tue, 09 Apr 2013 13:11:02 GMT

For the property comparison validators, like GreaterThan, it uses the destination property in the error message.

"Start Date should be greater than EndDate"

Though the system uses the DisplayName value for the current property, it should also use the DisplayName value for the destination property, if available.

"Start Date should be greater than End Date"
Comments: ** Comment from web user: peterrow **

I would say that the impact is medium or high.
Without this whenever a validation message is shown it is displayed incorrect, this looks bad to clients of my software. The only workaround is to hardcode the error message - not nice, especially for localisation.

Commented Issue: Issue - NotImplementedException [17357]

manuel0081 — Thu, 21 Feb 2013 11:03:04 GMT

http://forums.asp.net/post/4749014.aspx
 
http://forums.asp.net/t/1752975.aspx/1?Conditional+validation+with+MVC+Foolproof+Validation+
Comments: ** Comment from web user: manuel0081 **

related to #15609. Can be closed.

Commented Issue: "The method or operation is not implemented." - ValidationAttributes and Entity Framework 4 [15609]

manuel0081 — Thu, 21 Feb 2013 10:52:24 GMT

Hi,
 
There doesn't appear to be anything about this issue in the discussions or issue tracker. Must say, before I begin, I like what you've been doing and would very much like to make use of this library in my MVC 3 projects.
 
Anyway, it looks like there's an issue with the 'IsAttribute' attributes (not tested the RequiredIf attributes) when used in conjunction with the Entity Framework (I'm using EF 4.1 with Code First). When EF is trying to SaveChanges() the following exception is being raised:
 
[NotImplementedException: The method or operation is not implemented.]
 Foolproof.ModelAwareValidationAttribute.IsValid(Object value) +28
 System.ComponentModel.DataAnnotations.ValidationAttribute.IsValid(Object value, ValidationContext validationContext) +108
 System.ComponentModel.DataAnnotations.ValidationAttribute.GetValidationResult(Object value, ValidationContext validationContext) +29
 System.Data.Entity.Internal.Validation.ValidationAttributeValidator.Validate(EntityValidationContext entityValidationContext, InternalMemberEntry property) +107
 
Not hugely familiar with EF to be able to give you any detailed suggestions/fixes but, since the error is coming from ModelAwareValidationAttribute, I suspect the issue lies around when the validation attributes are being instantiated or something to do with the object inheritance hierarchy.
 
Hope this helps.
 
Cheers,
Jonny
Comments: ** Comment from web user: manuel0081 **

Impact low? change to urgent! It's related to Entity Framework... it's very important to resolve.

Commented Issue: "The method or operation is not implemented." - ValidationAttributes and Entity Framework 4 [15609]

manuel0081 — Thu, 21 Feb 2013 10:45:09 GMT

I have too

Created Issue: How to get VB.Net verion of this code (MVC Validation) [19216]

Pughalveni — Mon, 21 Jan 2013 11:21:07 GMT

Please let me know

Commented Issue: RequiredIf not working with radio buttons [18872]

nairik — Wed, 16 Jan 2013 09:03:22 GMT

Hi,
I want validate the radio button with reuiredIf attribute using dependent value but client side validation deosnt work for radio button. any help!!
Comments: ** Comment from web user: nairik **

Hi,

Same bug for me, but i suspect that client validation is not working when using sub classes inside your view model.

Example :

public class Test1ViewModel
{
public Test2ViewModel model2 {get;set;}
}

public class Test2ViewModel
{
public bool bool1{get;set;}

[RequiredIfTrue("bool1")] // This is not working on client side. Please fix this bug :)
public string string1{get;set;}

}

Created Issue: GreaterThan operator compare only days on 'dd M yy' formatted date [19185]

ynevet — Mon, 14 Jan 2013 08:27:52 GMT

When comparing 2 dates with the 'dd M yy' format using the GreaterThan operator:
Begin: 16 Jan 2013
End: 06 Feb 2013

The GreaterThan operator only check the days instead of the entire date(day, month and year) and as a result of it 16 days is greater than 06 days and the validation failed: 'Begin must be greater than End', which is obviously unwanted behavior.

Please help.

Thank you

Commented Issue: Support internation date and time formats [17417]

stare — Fri, 07 Dec 2012 06:41:55 GMT

Please add support for international date and time formats in client validation (unobtrusive)
 
Such as 'dd/mm/yyyy' and 'dd.mm.yyyy'

Comments: ** Comment from web user: stare **

Second that!

Commented Issue: RequiredIf using Regex against number field never validates [18974]

jwynveen — Mon, 26 Nov 2012 22:56:12 GMT

I have a state field that is only required if the user select USA or Canada from a dropdown. I used RequiredIf with the RegExMatch operator. This works perfectly with server side validation, but the unobtrusive validation never shows that field as invalid.

[RequiredIf("Country", Operator.RegExMatch, "(1033|4105)", ErrorMessage = "{0} is required")]
public string State { get; set; }

[Required(ErrorMessage = "{0} is required")]
public int Country { get; set; }

Looking at the source of mvcfoolproof.unobtrusive.js, the issue is because it is parsing value2 ("(1033|4105)") to a number because it sees that value1 ("1033") is a number. This makes the RegEx never fail because value2 is NaN.

Here is how I changed that block of code to make it work. Essentially I'm keeping the original values around even after being parsed, because you should never parse the regex pattern.

===== Code Fix =====
var originalValue1 = value1;
var originalValue2 = value2;
if (isDate(value1)) {
value1 = Date.parse(value1);
value2 = Date.parse(value2);
}
else if (isBool(value1)) {
if (value1 == "false") value1 = false;
if (value2 == "false") value2 = false;
value1 = !!value1;
value2 = !!value2;
}
else if (isNumeric(value1)) {
value1 = parseFloat(value1);
value2 = parseFloat(value2);
}

switch (operator) {
case "EqualTo": if (value1 == value2) return true; break;
case "NotEqualTo": if (value1 != value2) return true; break;
case "GreaterThan": if (value1 > value2) return true; break;
case "LessThan": if (value1 < value2) return true; break;
case "GreaterThanOrEqualTo": if (value1 >= value2) return true; break;
case "LessThanOrEqualTo": if (value1 <= value2) return true; break;
case "RegExMatch": return (new RegExp(originalValue2)).test(value1); break;
case "NotRegExMatch": return !(new RegExp(value2)).test(value1); break;
}
Comments: ** Comment from web user: jwynveen **

The other option would be to parse value1 and value2 separately since they very well could be different types. Something like this:

if (isDate(value1)) {
value1 = Date.parse(value1);
}
else if (isBool(value1)) {
if (value1 == "false") value1 = false;
value1 = !!value1;
}
else if (isNumeric(value1)) {
value1 = parseFloat(value1);
}
if (isDate(value2)) {
value2 = Date.parse(value2);
}
else if (isBool(value2)) {
if (value2 == "false") value2 = false;
value2 = !!value2;
}
else if (isNumeric(value2)) {
value2 = parseFloat(value2);
}
==end code==
That could obviously be cleaned up into a shared function that parses each value, but I think you get the point.

Created Issue: RequiredIf using Regex against number field never validates [18974]

jwynveen — Mon, 26 Nov 2012 22:51:49 GMT

Commented Issue: RequiredIfTrue not working with EditorTemplates [17819]

zbarrier — Sat, 17 Nov 2012 01:25:33 GMT

RequiredIfTrue doesn't work with EditorTemplates.
 
if have a list of RegistrationStepFields (List<RequiredStepModel>) wich a have an EditorTemplate for.
@Html.EditorFor(x => x.RegistrationStepFields, ViewData).
In my model i have bound the RequiredIf Attribute to the Value field like this: 
 
public bool Required { get; set; }
 
 [RequiredIfTrue("Required")]
 public string Value { get; set; }
 
the problem is that the View is rendered like this: 
<input type="hidden" value="True" name="RegistrationStepFields[1].Required" id="RegistrationStepFields_1__Required" data-val-required="The Required field is required." data-val="true" class="valid">
 
<input type="text" value="" name="RegistrationStepFields[1].Value" id="RegistrationStepFields_1__Value" data-val-requiredif-operator="EqualTo" data-val-requiredif-dependentvalue="True" data-val-requiredif-dependentproperty="Required" data-val-requiredif="Value is required due to Required being equal to True" data-val-remote-url="/Register/ValidateAlias" data-val-remote="Profile_Alias is valid" data-val="true" tabindex="1" class="dating-forminput dating-forminput-10 tooltip-enabled Profile_Alias valid" data-original-title="blabla">
 
so it seems like the foolproof validation is not aware of validation within a loop (EditorTemplate) so the validation is searching for a property wich doesn't exist.

Comments: ** Comment from web user: zbarrier **

Nick,

I have this same problem. My html contains the correct markup, but client side validation doesn't work. Have you had any luck in solving this?

Created Issue: RequiredIf not working with radio buttons [18872]

rahul8612 — Wed, 07 Nov 2012 10:00:40 GMT

Hi,
I want validate the radio button with reuiredIf attribute using dependent value but client side validation deosnt work for radio button. any help!!

Commented Issue: Could not load file or assembly System.Web.Mvc, Version=2.0.0.0 during unit test [18815]

jtu100 — Tue, 23 Oct 2012 13:25:38 GMT

I get the following exception when trying to run an NUnit test to verify AutoMappers configuration. I don't know why its looking for MVC 2.0? I am using MVC 4.0.0 dlls in my main app and Foolproof works fine at runtime.

Any ideas?

{{
System.TypeInitializationException : The type initializer for 'Foolproof.ContingentValidationAttribute' threw an exception.
----> System.IO.FileLoadException : Could not load file or assembly 'System.Web.Mvc, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
at System.Reflection.CustomAttribute._CreateCaObject(RuntimeModule pModule, IRuntimeMethodInfo pCtor, Byte** ppBlob, Byte* pEndBlob, Int32* pcNamedArgs)
at System.Reflection.CustomAttribute.CreateCaObject(RuntimeModule module, IRuntimeMethodInfo ctor, ref IntPtr blob, IntPtr blobEnd, ref Int32 namedArgs)
at System.Reflection.CustomAttribute.GetCustomAttributes(RuntimeModule decoratedModule, Int32 decoratedMetadataToken, Int32 pcaCount, RuntimeType attributeFilterType, Boolean mustBeInheritable, IList derivedAttributes, Boolean isDecoratedTargetSecurityTransparent)
at System.Reflection.CustomAttribute.GetCustomAttributes(RuntimePropertyInfo property, RuntimeType caType)
at AutoMapper.ConfigurationStore.CreateMappingExpression(TypeMap typeMap)
at AutoMapperConfig.Configure() in AutomapperConfig.cs: line 35
at MyApp.Test.AutomapperConfigurationTest.ValidationAutomapperConfiguration() in AutomapperConfigurationTest.cs: line 11
--FileLoadException
at Foolproof.Register.Attribute(Type foolprooftAttributeType)
at Foolproof.Register.All()
}}
Comments: ** Comment from web user: jtu100 **

I think the problem is caused by this line in the app config:

It explicitly references 2.0.0.0.

This is worked around in the main app by having a binding redirect. But during unit testing the app.config is not available.

Created Issue: Could not load file or assembly 'System.Web.Mvc, Version=2.0.0.0 during unit test [18815]

jtu100 — Tue, 23 Oct 2012 12:51:30 GMT

I get the following exception when trying to run an NUnit test to verify AutoMappers configuration. I don't know why its looking for MVC 2.0? I am using MVC 4.0.0 dlls in my main app and Foolproof works fine.

Any ideas?

System.TypeInitializationException : The type initializer for 'Foolproof.ContingentValidationAttribute' threw an exception.
----> System.IO.FileLoadException : Could not load file or assembly 'System.Web.Mvc, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
at System.Reflection.CustomAttribute._CreateCaObject(RuntimeModule pModule, IRuntimeMethodInfo pCtor, Byte** ppBlob, Byte* pEndBlob, Int32* pcNamedArgs)
at System.Reflection.CustomAttribute.CreateCaObject(RuntimeModule module, IRuntimeMethodInfo ctor, ref IntPtr blob, IntPtr blobEnd, ref Int32 namedArgs)
at System.Reflection.CustomAttribute.GetCustomAttributes(RuntimeModule decoratedModule, Int32 decoratedMetadataToken, Int32 pcaCount, RuntimeType attributeFilterType, Boolean mustBeInheritable, IList derivedAttributes, Boolean isDecoratedTargetSecurityTransparent)
at System.Reflection.CustomAttribute.GetCustomAttributes(RuntimePropertyInfo property, RuntimeType caType)
at AutoMapper.ConfigurationStore.CreateMappingExpression(TypeMap typeMap)
at AutoMapperConfig.Configure() in AutomapperConfig.cs: line 35
at OkFlatmate.Test.AutomapperConfigurationTest.ValidationAutomapperConfiguration() in AutomapperConfigurationTest.cs: line 11
--FileLoadException
at Foolproof.Register.Attribute(Type foolprooftAttributeType)
at Foolproof.Register.All()

Commented Issue: Issue - NotImplementedException [17357]

cammoorman — Wed, 22 Aug 2012 23:18:25 GMT

http://forums.asp.net/post/4749014.aspx

http://forums.asp.net/t/1752975.aspx/1?Conditional+validation+with+MVC+Foolproof+Validation+
Comments: ** Comment from web user: cammoorman **

Entity Frameworks and Telerik Open Access are equally affected.

Created Issue: RequiredIf can only be used once per property [18483]

jholovacs — Fri, 17 Aug 2012 18:06:54 GMT

There may be several cases where a property is required; this seems too limited. Is there a purpose behind restricting to only one instance per property?